tonsky / tonsky/datascript

Infinite loop in rule solver

Open
#277 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
5.8k
Forks
318
PR merge metrics
No merged PRs in 30d

Description

The following code will result in the query hanging

var ds = require("datascript")

var db = ds.db_with(ds.empty_db(), [
    {
        "left": "aaron",
        "right": "barbara"
    },
    {
        "left": "aaron",
        "right": "chris"
    }
])

var rules = `[
    [
        (friends ?a ?b)
        [?i "left" ?a]
        [?i "right" ?b]
    ]
    [
        (friends ?a ?b)
        (friends ?a ?c)
        (friends ?c ?b)
    ]
]`

console.log(ds.q(`[:find ?a ?b :in $ % :where (friends ?a ?b)]`, db, rules))

It's fairly similar to the transitive closure example in the README, but it uses an additional call to the rule in the non-base case. My understanding is that datalog queries should always terminate, so apologies if this isn't actually a bug.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the provided ds.db_with, ds.q, and rules reproduction, then compare it with the transitive-closure example in the README. Trace the rule solver reached by ds.q and verify that this recursive rule query terminates and returns the expected friends results.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, javascript
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.