tonsky / tonsky/datascript

Rules error

Open
#239 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
5.8k
Forks
318
PR merge metrics
No merged PRs in 30d

Description

After asking a couple of questions on the datascript slack, @tonsky asked me to make a gist with my error in it. The function (connected x y) should return a set of all diagonal neighbors of neighbors on a cartesian grid but in cases where the (= x y) it ignores neighbors that are also (= x y).

The gist is at https://gist.github.com/Tavistock/6305de1b890e3a60489544ae139b102f. for background this is for implementing a game of checkers or draughts.

This image shows the degenerate case where the orange highlighted checker is selected and the green squares are it's connected. Notice that (= x y) for the checker.
screen shot 2017-11-04 at 2 30 19 pm

This image shows the correct highlighting when selecting a different piece and using connected. Notice that (!= x y) for the checker.
screen shot 2017-11-04 at 2 30 34 pm

My question is whether there is an error in my code and reasoning, or if this is a problem with Datascript.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked gist and the (connected x y) function, then reproduce the Cartesian-grid case where (= x y) omits neighbors that also satisfy that condition. Compare it with the non-equal case and determine whether the behavior comes from the reported code or Datascript. Done means identifying the cause and confirming the expected diagonal-neighbor set.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.