tonsky / tonsky/FiraCode

"x" in 0xFF is confusing

Open
#944 16 comments 24 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

>>> hex(1234)
'0x4d2'

returns something that looks not like 0x4d2 but 0×4d2. You are not solving anything with this substitution, you changed meaning of the content.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by rendering the shown hex(1234) output in Fira Code and compare the x in 0x4d2 with the expected ASCII x. Done means the hexadecimal prefix remains visually unambiguous and does not render as a multiplication sign; the payload names no files or tests to inspect.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.