tonsky / tonsky/FiraCode

Some ligatures still enabled in regex groups

Open
#847 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

I notied this when reading through the changelog for v2 (AWESOME update by the way, thank you!). A few of the ligatures listed as being disabled are still being partly applied. I copied the text and made a quick gif to show which ones are still behaving a little oddly.

This is probably an edge case (I don't think I would have ever noticed if not for the fact that I have Fira Code enabled in a GitHub user style), but thought you'd like to know.

ligatures

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the v2 changelog's list of disabled ligatures with the behavior shown in the attached GIF, focusing on regex groups. Reproduce the issue with Fira Code enabled in a GitHub user style; done means the listed ligatures are no longer partly applied in regex groups.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.