tonsky / tonsky/FiraCode

Vertical position change between 1.207 and 2

Open
#833 13 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Using Kitty and Tmux on macOS with FiraCode 1.207:
Screen Shot 2019-09-10 at 10 59 53

Same configuration but with FiraCode 2:
Screen Shot 2019-09-10 at 10 56 15

The text is no longer vertically centered in the colored background cell.

Additionally, I noticed that for both versions, the text on the background is not vertically aligned with text on the default background.
With 1.207:
Screen Shot 2019-09-10 at 11 03 38

With 2:
Screen Shot 2019-09-10 at 10 56 41

It's worse with the new version and I had never noticed the discrepancy before with the old version but this may be the same issue.

I am happy to provide further information about my configuration. Please let me know what information would be useful.

EDIT: I tried the same experiment in Terminal.app, which is using the default "Pro" theme except for the font changed to Fira Code Regular 14pt.
With 1.207:
Screen Shot 2019-09-10 at 11 14 52

With 2:
Screen Shot 2019-09-10 at 11 14 23

In this case, with the new version, the text is too low. 😞

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No project files or tests are named. Reproduce the vertical alignment difference with Fira Code 1.207 and 2 in Kitty and Tmux on macOS, then compare the colored and default background cells and the Terminal.app results. Done means the text is vertically aligned consistently across these cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.