tonsky / tonsky/FiraCode

HTML comment ligature bang does not align with followup lines

Open
#1,631 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

It would be nice if the exclamation marks aligned:

<!--
 ! Hello world!
 ! This is a comment.
 !-->

Similar to how C-style comments align the asterisk for certain types of comments:

/*
 * Hello world!
 * This is a comment.
 */

Fira unfortunately breaks the alignment for HTML-style comments written this way.

This is about the starting <!-- specifically. As of now I haven't thought about !--> (with a space before the bang), because it does not misalign.

This comment style can for example be found in the source of the HTML specs repo.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the issue's HTML and C examples as the behavioral reference, focusing first on the ligature formed by the opening <!--. Compare the rendered alignment of the opening bang with the following ! lines; done means the HTML comment example aligns like the C-style example without changing the already-aligned closing form.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.