tonsky / tonsky/FiraCode

v2 heights were much better in a terminal with background colors

Open
#1,579 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

When background colors exist in a terminal, the character cells glyphs within a character cell in Fira Code v6.2 are taller than in v2.0, which causes the tops of characters to be too close to the bottom of the background of text in the line above it.

Is there some way to compile the font using the old v2.0 vertical spacing?

I've been continuing to use v2.0 for years now, because Fira Code is my favorite font but the heights after v2.0 are not as conducive for use in a terminal where background colors are applied.

For example, look at each line with a background color in the screenshot below, versus the line below it. Especially for the [] on the last line in the screenshot. Also, it looks "off" to have half the space above a capital letter as below the capital letter (particularly visible when a run of text has a background color different from the rest of the terminal display).

Also, I just noticed that the vertical position of a strikethrough line is way off in v6.2, at least when rendered by Windows Terminal (look at the green text immediately below the "Debt" line in the screenshot).

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named. Start by comparing the vertical metrics and strikethrough placement between the v2.0 and v6.2 font builds, reproducing the issue in a terminal with background colors and Windows Terminal. Done means the newer build has the intended line spacing and strikethrough position without regressing the font's other rendering behavior.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.