tonsky / tonsky/FiraCode

Ligatures involving double colon ("::") and an angle bracket are misaligned

Open
#1,557 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

conflict
Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

See this image:

image

In C++, this form of qualified identifier is commonly used with templated classes:

TemplatedClass<TemplateParam>::SomeMemberIdentifier

It looks like ligatures and/or kerning adjust the second colon up to align with the first letter of the following word, and adjust the first colon down to align with the closing > character.

Consecutive ::s should probably stay aligned with each other when possible!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the attached image and the C++ example TemplatedClass<TemplateParam>::SomeMemberIdentifier to reproduce the misalignment. The issue names no files, tests, or entry points; done means consecutive :: characters remain aligned in this ligature and angle-bracket context.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.