tonsky / tonsky/FiraCode

Digit 9 height inconsistent with rest

Open
#1,515 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Question

Is alignment of digits of default stylistic set (no feature selected) supposed to be equal at top and bottom bounds? I really like Fira Code overall, yet cannot use it at the moment as I fail to ignore the seeming inconsistency. Maybe there's a solution.

Observation

I cannot quite tell if 9 is misaligned or actually taller than the other digits, but in different terminals on Wayland (foot, alacritty, kitty, wezterm) it sticks out anytime there's a 9 on display within other digits:
image

After taking a screenshot and marking the bottom, it looks like 3 is the same:
image

And looking at the top, 1 doesn't align with 9 and seems like neither does it with 3 (slightly):
image

Same result with GTK3's font renderer:
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the reported digit rendering in foot, alacritty, kitty, wezterm, and GTK3 using the screenshots as reference. Done means determining whether the 1, 3, and 9 share the same top and bottom alignment and documenting the required font change.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.