tonsky / tonsky/FiraCode

Ligatures display incorrectly for "fi" when cv06 enabled

Open
#1,497 5 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

contextual
Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

When I enabled cv06 in the build, it displayed character "i" incorrectly in the combo "fi" despite the choice of ss10, but trivial "i" or other combos are correct.
Please see the example in the following picture.
image

The font was built with docker by the following command:

docker run --rm -v "$PWD":/opt tonsky/firacode:latest ./script/build.sh -f "cv01,cv02,cv06,ss01,ss05,ss04,ss03,cv
30,ss08,ss09,cv25,cv26,cv32,cv28,ss06,ss07"

A newfound: this issue happens in the kitty terminal and Windows terminal I used but doesn't seem to be a problem in the terminal in VSCode. Note that I have ligatures enabled in all of those terminals.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the font with the provided Docker command and script/build.sh, then compare the “fi” rendering with cv06 and ss10 enabled in kitty and Windows Terminal against VSCode. Done means the “i” renders correctly in the “fi” ligature without regressing standalone “i” or the other combinations.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.