tonsky / tonsky/FiraCode

Clash between greater_equal and less_equal signs and equals arrow combinations

Open
#1,427 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

<= <== ==> =>
>= >== ==< =<

produces:
Screen Shot 2022-06-27 at 10 46 28 am

There's inconsistency between <= => >= and =<
I know that <= and >= is supposed to produce the greater_equal and less_equal ligatures but there's a clash in the subsitution logic here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two-line input shown in the issue and compare the rendered ligatures for each sequence. Trace the substitution logic responsible for <=, =>, >=, and =<, then add or update a regression case covering the conflicting combinations. Done means the four combinations render consistently without unintended substitutions.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.