tonsky / tonsky/FiraCode

Make progress start/end single character

Open
#1,394 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Unicode
Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

@tonsky - I have an idea: you could add a ligature for the new FiraCode progress bar chars themselves, for the case where a bar is 100% completed. Some progress bar libraries allow setting a "theme" for the bar, with characters for bar start, filled progress, empty progress, and bar end, but do not have a concept of two different characters for bar end depending on whether the progress has reached 100% or not.

This results in a progress bar that looks slightly incomplete:

image

A ligature could solve that by replacing the sequence \uee04\uee02 (filled bar, empty end) with \uee04\uee05 (filled bar, filled end).

Even without all the application-specific ligatures, I think this would be useful.

Originally posted by @joelnordell in https://github.com/tonsky/FiraCode/issues/1183#issuecomment-1071042997

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing FiraCode ligature definitions for the progress bar characters mentioned in the issue. Implement the requested transformation from \uee04\uee02 to \uee04\uee05, then verify that the completed bar renders with the filled end character.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.