tonsky / tonsky/FiraCode

Ligature request: Mermaid's Entity Relationship Diagram

Open
#1,377 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

suggestion
Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Would it be possible to add ligatures for Mermaid's ERD relationship notation?
As it is not a common use case, adding them as variants might be preferable.

Syntax specification:

  • Either
    • |o
    • ||
    • }o
    • }|
  • Always --
  • Either
    • o|
    • ||
    • o{
    • |{

Examples: }o--||, |o--|{

Possible problems may arise, as ||, |- and -| are already ligatures.
Hard-coding every possibility could possibly work.

Design:

  • Either skewering them together on a line, and putting the characters closer
    image
  • Or resembling the actual mermaid output (see the arrows in the image below)
    image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing ligatures for ||, |-, and -|, then compare the requested Mermaid ERD combinations such as }o--|| and |o--|{ with the two proposed visual designs. Done means the supported combinations render consistently without breaking the existing ligatures, with the final design choice resolved.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.