tonsky / tonsky/FiraCode

Static member access doesn't render :: correct on template classes

Open
#1,346 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

conflict
Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

With C++, the double colon ligature doesn't render when accessing a static member of a template class. But it works fine on a regular class.

image

I am guessing it could be related to #1329, (and #1145) but thought I would play it safe and create its own issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reported C++ template-class example and compare it with the regular-class case shown in the attached image; review issues #1329 and #1145 for related context. Done means the double-colon ligature renders correctly for static-member access on template classes without regressing regular classes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.