tonsky / tonsky/FiraCode

Ligature variant needed for the ReScript language

Open
#1,321 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

conflict stylistic sets
Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Hi!

First of all, thanks for this beautiful font. I've been using it for a couple of years, without issues. However, with the ReScript language, there's an annoying ligature in the following snippets showcasing optional labelled arguments syntax in combination with generics:

  ~title: option<string>=?,
  ~getDocumentImpl: DocumentPicker.options => Promise.t<
    DocumentPicker.result,
  >=DocumentPicker.getDocumentAsync,
image image

It would be great if we had a variant that disallows the "greater than or equal" ligature in case there's any non-whitespace character after the >= sequence. In that case, I'd be able to use it specifically in ReScript files.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the ReScript snippets in FiraCode and compare the current greater-than-or-equal ligature behavior with the requested context. Done means a usable variant prevents that ligature when a non-whitespace character follows >= while preserving the existing behavior elsewhere.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.