tonsky / tonsky/FiraCode

HTML self-closing tag `/>` issue

Open
#1,269 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
82k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Using a regular 1:1 DPI screen on Windows 10. I have a custom style sheet that replaces many <code> and such styles with Fira Code, e.g. on GitHub:

.diff-editor *, code, pre {
    font-family: "Fira Code" !important;
    font-size: 10pt;
    font-variant-ligatures: common-ligatures;
    line-height: 1.3 !important;
}

One issue that happens can be seen in the README here: https://github.com/vuejs/jsx-next where the closing slashes of the tags are almost invisible:

image


Computed styles (according to Firefox)

box-sizing: border-box;
color: rgb(0, 92, 197);
font-family: "Fira Code";
font-size: 13.6px;
font-variant-ligatures: common-ligatures;
line-height: 17.6833px;
overflow-wrap: normal;
word-break: normal

The ligature works in normal sizes elsewhere and is not cut off (so it might perhaps be a Firefox issue)?

Forcing font-size: 20px; resolves the issue, but is a bit too large for my taste:
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the README rendering from https://github.com/vuejs/jsx-next in Firefox on Windows 10 with the reported custom CSS and Fira Code at 13.6px, then compare it with the 20px result. No project file or test is identified; the issue is done only when the rendering cause and an actionable fix or upstream report are established.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
design, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.