tomas / tomas/needle

Cannot read properties of undefined (reading 'query')

Open
#445 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.6k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

With the last 3.4.x and 3.5.0 versions we are seeing:

Cannot read properties of undefined (reading 'query')
    at module.exports.<computed> [as get] (/usr/src/app/node_modules/needle/lib/needle.js:863:44)

We see the error in a simple get call needle.get(<url to a file on a s3 bucket with public visibility>).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at needle.js line 863, where the stack trace reports the failed get call, and reproduce the issue with a public S3 file URL using the affected 3.4.x or 3.5.0 version. Trace why the simple needle.get call reaches an undefined value, then verify that the request completes without the reported error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.