tomas / tomas/needle

Wrong euro symbol

Open
#352 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.6k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

For example, I get html with encoding <meta charset = "utf-8">

I am making multiple requests to the same url.

In response.body, I sometimes see the correct text:
&#x20AC; 9.99 <br>
But usually this text is incorrect:
&#xFFFD; &#xFFFD; 9.99 <br>

This text is always correct if I get text from
response.raw.toString ()

Also this text is always correct if I use the old version of "needle": "^ 2.2.4"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the repeated requests described in the issue and compare response.body with response.raw.toString() for the euro response. Then trace the response decoding path in needle and compare it with version 2.2.4. Done means response.body consistently preserves the euro symbol instead of replacement characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.