tomas / tomas/needle

Shouldn't we check if complete message was downloaded?

Open
#346 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.6k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

This doc describes that complete property can be used to check if entire message was downloaded: https://nodejs.org/api/http.html#http_message_complete

Won't this check be helpful especially when transfer-encoding: chunked is used by server?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Node.js http.IncomingMessage documentation linked in the issue, focusing on the complete property and chunked transfer encoding. Trace how Needle handles downloaded HTTP messages, then establish whether incomplete messages are detected and what test should demonstrate the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.