tocwex / tocwex/fund

Fix values in oracles initial signed message

Open
#28 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

nitpick
Dominant language
hoon
Stars
12
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Signature request had an interesting value for milestone 3 cost: 2e3....
https://sfo3.digitaloceanspaces.com/sarlev-sarsen/sarlev-sarsen/2024.4.14..20.32.10..72b0.20c4.9ba5.e353-image.png
As @sidnym-ladrut notes, "Yeah that's just scientific notation, which is what Urbit's pretty printer uses by default when rending floating-point @rs values with many decimals. I'm 90%+ sure that we'll be moving to @ud bigints to store money values in the V2 release, so this won't matter for long."

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files, tests, or entry points are identified in the issue. First verify whether the scientific-notation value in the oracle's initial signed message still occurs and whether the planned V2 bigint change has superseded this report; done means the affected value is represented as intended without breaking message signing.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.