tocwex / tocwex/fund

Financial Amount formatting

Open
#21 4 comments 0 reactions 1 assignee View on GitHub

@sidnym-ladrut is already working on this.

Since Mar 21, 2024.

nitpick
Dominant language
hoon
Stars
12
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Our good friend ~mopfel-winrux is a monster and pledged something like .094 to my test project. Nothing broke, but it did expose a few interesting things:

image
^the pledged value supported up to 3 decimals of granularity

image
^while the 'unfunded' value seemed to round up to 2 decimals

image
^and the Proposal funders section rounded to a single decimal point

We should have all financial values round to the single dollar and restrict the front end form the same way. People committing less than a dollar should be mocked ruthlessly at least until we have a basically-free L2 to put this on.

Additionally, we should support commas for values in the 1,000s/1,000,000 etc.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.