list_windows: We may be filtering out `window_name: ''` and `''` values

Open
#445 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Start at the list_windows implementation and inspect its filtering logic, then review the test referenced in #444. Confirm how an empty window_name and other empty-string values are handled, and ensure existing empty values are retained.

Written by the indexing model from the issue text.

Description

#444 it seems the test will always pass, even before the change that, when verified by hand, permits window_name: '' to work (or else it'd default to zsh or whatever the shell name was for the window)

See if our filtering is negating '' as a falsey value. We want to keep those, if they exist.

Fulll context: https://github.com/tmux-python/libtmux/pull/444#discussion_r980591231

Dominant language
Python
Stars
1.2k
Forks
127
Avg merge
2h 13m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tmux-python/libtmux

All issues in tmux-python/libtmux

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.