tkhq / tkhq/tkcli

Set defaults for private key generation

Open
#29 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
22
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Private key generation via cli is quite verbose:

turnkey pk create --key-name some-key --address-format ADDRESS_FORMAT_ETHEREUM --curve CURVE_SECP256K1 --name some-name

We should consider making --address-format and --curve optional, with defaults set to ADDRESS_FORMAT_ETHEREUM and CURVE_SECP256K1 respectively.

Furthermore, we could probably flesh out the flags:

private-keys interacts with private keys

Usage:
  turnkey private-keys [command]

Aliases:
  private-keys, pk

Available Commands:
  create      create a new private key
  list        list private keys for the organization

Flags:
  -h, --help   help for private-keys

Global Flags:
  -k, --key-name string       name of API key with which to interact with the Turnkey API service (default "default")
  -d, --keys-folder string    directory in which to locate keys (default "/Users/andrew/Library/Application Support/turnkey/keys")
      --organization string   organization ID to be used
  -o, --output string         output format (default "json")

Use "turnkey private-keys [command] --help" for more information about a command.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CLI entry points for turnkey private-keys create and its pk alias, then inspect the existing flags and help output. Done means --address-format and --curve are optional with the requested defaults, and the private-key command help clearly documents the available commands and flags.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.