titzer / titzer/wizard-engine

Test failure with incorrect stack state

Open
#634 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
WebAssembly
Stars
512
Forks
51
Avg merge
7h 34m
Merged PRs (30d)
21

Description

The following test fails on all targets:

sup06.zip

bin/wizeng --trace-stack 

sup06.bin.wast 
##>1
##+/tmp/sup06.bin.wast
Batch allocating 8 stacks
Requested fresh x86_stack @ 0x08424578
!X86_64StackError: resume() requires state == RESUMABLE, got SUSPENDED
	in X86_64Stack.fatal() [src/engine/x86-64/X86_64Stack.v3 @ 591:29]
	in X86_64Stack.checkState() [src/engine/x86-64/X86_64Stack.v3 @ 325:46]
	in X86_64Stack.resume() [src/engine/x86-64/X86_64Stack.v3 @ 72:27]
	in X86_64StackManager.runOnFreshStack() [src/engine/x86-64/X86_64Stack.v3 @ 961:62]
	in X86_64InterpreterOnlyStrategy.call() [src/engine/x86-64/X86_64Target.v3 @ 209:58]
	in Execute.call() [src/engine/Execute.v3 @ 18:36]
	in SpecTestInterpreter.doInvoke() [test/wasm-spec/SpecTestInterpreter.v3 @ 248:42]
	in SpecTestInterpreter.doAction() [test/wasm-spec/SpecTestInterpreter.v3 @ 223:48]
	in SpecTestInterpreter.doCommand() [test/wasm-spec/SpecTestInterpreter.v3 @ 80:49]
	in SpecTestInterpreter.run() [test/wasm-spec/SpecTestInterpreter.v3 @ 60:34]
	in SpectestMode.runTest() [src/SpectestMode.v3 @ 68:35]
	in SpectestMode.run() [src/SpectestMode.v3 @ 26:51]
	in main() [src/wizeng.main.v3 @ 96:48]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with bin/wizeng --trace-stack using sup06.bin.wast from sup06.zip. Read X86_64Stack.resume(), checkState(), and X86_64StackManager.runOnFreshStack() at the stack-trace locations, then follow the call from SpecTestInterpreter.doInvoke(). Done means the supplied test no longer raises the incorrect SUSPENDED-state error on the affected targets.

Written by the indexing model from the issue text.

Assessment

Tech stack
wasm
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.