Usability issue: overlays should never make the page overflow

Open
#748 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Domain
frontend

Research direction

Start by locating the Debug Logs and Virtual Media overlay implementations and review how their content currently determines height. Ensure each overlay keeps its actions visible within the viewport while overflowing content becomes scrollable; verify the result against the 13-inch-screen baseline described in the issue.

Written by the indexing model from the issue text.

Description

bug medium

We currently have two overlays that can dynamically grow vertically: Debug Logs and Virtual Media.

This is inconvenient, because the overlay content might push actions out of the view port, which makes it harder to reach or even discover them.

We could introduce (and implement) a policy that overlays should always be fully visible (say at least on a 13" screen as baseline). It’d be up to the specific overlay then to take care of limiting its contents’ height and make the parts scrollable that overflow.

This issue is similar (maybe alternative?) to https://github.com/tiny-pilot/tinypilot/issues/715. It’s still important in its own right, because e.g. for Virtual Media there are other buttons apart from the “Close” one that would be pushed down.

Just for reference: below is a screenshot of the browser window at my 13" laptop screen and the debug logs overlay with limited height. For Virtual Media, there’d be space for around 8 backing files. So I’d say the remaining height is still big enough.

Screenshot 2021-07-19 at 15 48 52
Dominant language
Python
Stars
3.5k
Forks
291
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tiny-pilot/tinypilot

All issues in tiny-pilot/tinypilot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.