tiny-pilot / tiny-pilot/tinypilot

Provide “go back” functionality in error dialog

Open
#716 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
3.5k
Forks
291
PR merge metrics
No merged PRs in 30d

Description

As pointed out in https://github.com/mtlynch/tinypilot/pull/708, when an error occurs in a dialog, the user effectively hits a dead end. In order to start over they have to close the overlay and start the dialog again manually from the menu. In some cases (e.g. Virtual Media) this can be annoying.

This would require us to unify the initialization procedure of the dialogs in some way, so that we can reinitialize the dialog from other places as well (not just from the menu event handlers in app.js).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in app.js, where dialog initialization is currently handled by menu event handlers, and trace how error dialogs are opened and closed. Done means an error dialog offers a way to go back and reinitialize the dialog without closing the overlay and launching it again manually, including the Virtual Media case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.