tiny-pilot / tiny-pilot/tinypilot

Avoid setting permissions recursively in TinyPilot Debian package

Open
#1,196 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
3.5k
Forks
291
PR merge metrics
No merged PRs in 30d

Description

Debian packages are not supposed to set permissions recursively in maintainer scripts:

https://lintian.debian.org/tags/recursive-privilege-change

We recursively call chown in postinst so we should figure out a way to avoid doing that:

https://github.com/tiny-pilot/tinypilot/blob/db00936f8caff794a831ec0a72b9cf0a78fbbc52/debian-pkg/DEBIAN/postinst#L3

Once we figure out the "right" way of handling this, we should remove the lintian rule suppression:

https://github.com/tiny-pilot/tinypilot/blob/0ef51cafd5d7091f272fc12218982dd9097d72dc/.lintianignore#L13-L15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with debian-pkg/DEBIAN/postinst, especially the recursive chown, and review the recursive-privilege-change lintian rule. Determine a Debian-compliant way to set ownership without recursive changes, then remove the corresponding suppression from .lintianignore and verify the package no longer triggers that lintian warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.