tilt-dev / tilt-dev/tilt

modify the entrypoint of a CRD container that uses PodTemplateSpec

Open
#5,948 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
10.1k
Forks
413
Avg merge
1d 10h
Merged PRs (30d)
6

Description

Describe the Feature You Want

Imagine you're using Argo Rollout to deploy images

The RolloutSpec uses a v1.PodTemplateSpec.
https://pkg.go.dev/github.com/argoproj/argo-rollouts@v1.3.1/pkg/apis/rollouts/v1alpha1#RolloutSpec

Tilt should be able to inject an entrypoint into this CRD with docker_build(entrypoint=...) because it should be able to detect this is a PodTemplateSpec (similar to a Deployment)

Current Behavior

Tilt emits an error

command overrides only supported on containers with images, not on CRDs 
Why Do You Want This?

would make docker_build_with_restart work out of the box with ArgoRollout, and let us skip a bunch of k8s_kind stuff with CRDs

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the command-override handling that currently rejects CRDs, then compare it with the existing Deployment handling for PodTemplateSpec detection. Use the Argo RolloutSpec reference and the docker_build(entrypoint=...) and docker_build_with_restart paths; done means an Argo Rollout can receive the entrypoint without the CRD error and no longer needs the described k8s_kind workarounds.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.