Should . be ignored in dockerignore files per Docker docs?

Open
#5,894 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
docker
Domain
build-system

Research direction

Start at the docker_build entry point and trace how .dockerignore patterns are interpreted, comparing the behavior with Docker's documented handling of the . pattern. Done means a . entry is ignored and root files remain referenceable, with a regression test covering this case.

Written by the indexing model from the issue text.

Description

bug

Describe the Feature You Want

.dockerignore files, if present, should not acknowledge the use of . as a character when leveraging docker_build or similar in Tilt.

Current Behavior

If . is in a .dockerignore file, the build fails when trying to reference files at root by name.

Why Do You Want This?

It's entirely possible that this isn't necessary and entirely frivolous, but I'm implementing a Tilt-based workflow in several repositories, some of which have . in their .dockerignore files. In existing practices, this doesn't matter as docker-compose doesn't seem to care about it. If you look at Docker documentation:

https://docs.docker.com/engine/reference/builder/#dockerignore-file

For historical reasons, the pattern . is ignored.

This was not the case when using Tilt, latest version. v0.30.5, built 2022-07-14

Additional context
Add any other context or screenshots about the feature request here.

Dominant language
Go
Stars
10.1k
Forks
413
Avg merge
1d 10h
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tilt-dev/tilt

All issues in tilt-dev/tilt

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.