readiness probe verbosity
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Go
- Stars
- 10.1k
- Forks
- 413
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 6
Description
Our storybook server has a readiness probe like this:
local_resource(
'storybook',
serve_cmd='yarn run storybook -- --ci',
links=['http://localhost:9009'],
readiness_probe=probe(http_get=http_get_action(port=9009)),
labels=["frontend"])
When it succeeds, it prints the complete HTML returned by the server
What do you all think of either (a) truncating at some max length, or (b) defaulting to some other kind of log (like an apache-style HTTP log)? cc @milas
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the Storybook local_resource configuration and inspect the readiness_probe=probe(http_get=http_get_action(port=9009)) output path. Determine whether the desired behavior is truncation or an HTTP-style log, then verify that successful probes no longer print the complete HTML response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100