tilt-dev / tilt-dev/tilt

URLs in logs are sometimes broken because of extraneous characters

Open
#4,705 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
10.1k
Forks
413
Avg merge
1d 10h
Merged PRs (30d)
6

Description

Expected Behavior
  1. In logs, click a link:
{'id': '2342342', 'url': 'https://foo.com',}
  1. See URL in new tab: https://foo.com
Current Behavior
  1. In logs, click a link:
{'id': '2342342', 'url': 'https://foo.com',}
  1. See URL in new tab: https://foo.com', — broken 😞
Steps to Reproduce
  1. Go to Resource View to view logs that includes URL in JSON
  2. Click on URL
Context

This was observed in a user interview on 2021-06-28.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Resource View, where the issue reproduces when a URL appears in JSON logs and is clicked. Trace the URL-link handling from that view and verify the result against the example: the new tab should open https://foo.com without the trailing quote or comma.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability-sre
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.