custom_builds can hang forever
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Go
- Stars
- 10.1k
- Forks
- 413
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 6
Description
When we were iterating on a tiltfile, we accidentally made the mistake of having a custom_build like this:
custom_build(
'bazel/snack',
'bazel run //snack:image',
["."],
tag="image",
)
This will run the server and hang forever. The only way to stop it is to kill Tilt.
We should either have a timeout on custom builds, or a way to cancel the build from the tilt UI (or, maybe, both)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the custom_build execution path and the Tilt UI entry points mentioned in the issue. Reproduce the hanging bazel command, then determine whether the completed change should provide a timeout, UI cancellation, or both, with a test or manual check showing that a long-running custom build can be stopped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100