tilt-dev / tilt-dev/tilt

Better error page when no permissions to view team

Open
#3,595 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
10.1k
Forks
413
Avg merge
1d 10h
Merged PRs (30d)
6

Description

On Tilt Cloud, when I try to view a team I don't have permissions for, the server returns 403 (reasonable) but the error page is unhelpful:

Screen Shot 2020-07-17 at 5 42 27 PM

It seems like it's an internal error and not something expected like "you don't have permission to view this team".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Tilt Cloud case described in the issue by viewing a team without permission and inspect the resulting 403 page. No files or tests are named in the payload, so locate the error-page handling and permission response first. Done means the response clearly tells users they do not have permission to view the team instead of appearing as an internal error.

Written by the indexing model from the issue text.

Assessment

Domain
api, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.