tilt-dev / tilt-dev/tilt

Support helm `set-string` parameter in `helm`

Open
#3,559 2 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
10.1k
Forks
413
Avg merge
1d 10h
Merged PRs (30d)
6

Description

Due to the magic of YAML and dynamic typing it can be difficult to force a field to be of a certain type. For example if you use --set to set foo to "true" "true" will actually become the integer 1. This problem is described more in depth here.

To get around this Helm has a --set-string flag that forces the value that is being set to be a string. We should add support for this as a parameter to the helm builtin.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the helm builtin and its existing --set parameter handling, then find the related tests if present. Trace how values are passed to Helm and add coverage showing that --set-string preserves string values; done means the builtin accepts and forwards this parameter correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, helm
Domain
cli, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.