docker-compose image builds shouldn't overwrite default tag
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 10.1k
- Forks
- 413
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 6
Description
Create a docker-compose file like:
fe:
image: frontend:prod"
and an image build like:
docker_build("frontend:prod", ...)
Expected result:
Tilt should create a temporary tag and inject that into the docker-compose yaml
Actual result:
Tilt retags the image as "frontend:prod". This isn't good for teams that want frontend:prod to only refer to prod builds, not dev builds
Other notes:
The Tilt Kubernetes integration works correctly, and uses the yaml-rewriting approach
Currently, we don't have a good way to rewrite the docker-compose yaml, though Maia was experimenting with an approach here: https://github.com/windmilleng/tilt/pull/3200
Reported as an issue in the #tilt channel
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the docker-compose YAML rewriting approach described in the issue and the related pull request #3200, then compare it with the existing Kubernetes integration. Done means a compose service using image frontend:prod builds with a temporary development tag while frontend:prod remains reserved for production builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, docker-compose
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100