wrong usage of gRPC interface
Open
type/development
- Dominant language
- Go
- Stars
- 1.2k
- Forks
- 783
- Avg merge
- 5d 21h
- Merged PRs (30d)
- 36
Description
I see stack is attached to raw gRPC error `io.EOF` when client is closed
https://github.com/tikv/pd/blob/f18af797077127df932b06aa357587eacdd6b93d/server/grpc_service.go#L1045-L1052
but at caller it directly compares with `io.EOF`, so the extra stack fails the comparison
https://github.com/tikv/pd/blob/f18af797077127df932b06aa357587eacdd6b93d/server/grpc_service.go#L1079-L1084
Contributor guide
Research direction
Read server/grpc_service.go around lines 1045-1052 and 1079-1084 to trace how the gRPC error is produced and compared at the caller. Confirm the client-closed path preserves the intended io.EOF comparison, and verify that the extra stack no longer prevents the comparison from succeeding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100