Updating config is not atomic
Open
affects-8.1
affects-8.5
may-affects-5.4
may-affects-6.1
may-affects-6.5
may-affects-7.1
may-affects-7.5
severity/major
type/bug
- Dominant language
- Go
- Stars
- 1.2k
- Forks
- 783
- Avg merge
- 5d 21h
- Merged PRs (30d)
- 36
Description
## Bug Report
https://github.com/tikv/pd/blob/a6e855eef6744adfac232833769219be4f806756/pkg/dashboard/adapter/manager.go#L182-L186
Consider that we update the config using API at the same time, the timeline could be:
1. The dashboard first gets config and clone it
2. API finish updating config
3. The dashboard updates its config in the last
Step 2's updates could be overridden.
Contributor guide
Assessment
This issue has not been assessed yet.