tikv / tikv/pd

server: whether check eof in forward stream

Open
#6,174 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
1.2k
Forks
783
Avg merge
5d 21h
Merged PRs (30d)
36

Description

## Enhancement Task

We check stream whether meets eof in [ReportBuckets](https://github.com/tikv/pd/blob/a330f0b523f0243c1b0455bd9222b5c247d4f7f5/server/grpc_service.go#L837),[RegionHeartbeat](https://github.com/tikv/pd/blob/a330f0b523f0243c1b0455bd9222b5c247d4f7f5/server/grpc_service.go#L912) and [TSO](https://github.com/tikv/pd/blob/a330f0b523f0243c1b0455bd9222b5c247d4f7f5/server/grpc_service.go#L181) when recieving.

But we don't judge errors in the forward stream, I am not sure whether need to do it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.