tikv / tikv/pd

keyspace: validate etcd endpoints before adding meta-service groups

Open
#11,209 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
1.2k
Forks
783
Avg merge
5d 21h
Merged PRs (30d)
36

Description

## Enhancement Task

When a meta-service group is added through runtime configuration, PD currently
accepts its configured etcd endpoints without checking whether each target
server is reachable and healthy. A later status update could therefore enable
a group with an unusable endpoint.

Before persisting a newly added meta-service group, validate every
comma-separated etcd endpoint. Reject the addition when any endpoint fails the
etcd health check, so only a group with reachable endpoints can subsequently
be enabled through the existing status API. New groups remain disabled by
default; this task does not add configuration-based enablement.

Implementation covers the generic `/config` path, v2 meta-service-group API,
and pd-ctl. Tests verify successful checks, rejection without persistence, and
API/CLI behavior.

Contributor guide

Open the contributing guide

Research direction

Start with the generic /config path, the v2 meta-service-group API, and pd-ctl, then locate the existing etcd health-check logic. Done means every comma-separated endpoint is checked before persistence, unhealthy additions are rejected without saving, and the successful, API, and CLI behaviors are covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend-api-design, cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.