tikv / tikv/pd

Fix flaky tests in Eventually assertions to prepare for testify v1.11.0 upgrade

Open
#10,164 0 comments 0 reactions 0 assignees View on GitHub
component/testing type/enhancement
Dominant language
Go
Stars
1.2k
Forks
783
Avg merge
5d 21h
Merged PRs (30d)
36

Description

## Enhancement Task

### Background

Following the introduction of https://github.com/stretchr/testify/pull/1427, we have observed a significant increase in the failure rate of flaky tests involving `Eventually` assertions within the project.

### Problem

The changes in testify's `Eventually` implementation have exposed underlying instabilities in our current test suite. To maintain CI stability and ensure a smooth transition to the upcoming testify v1.11.0, these flaky tests must be addressed.

### Goals

- Identify and fix all unstable tests triggered by the new `Eventually` behavior.
- Strengthen CI quality by reducing non-deterministic failures.
- Unblock the upgrade to testify v1.11.0 (and subsequent versions).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.