tikv / tikv/client-rust

Improve RetryableMultiRegion

Open
#337 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
425
Forks
163
Avg merge
10h 51m
Merged PRs (30d)
3

Description

In #332, we add a parameter preserve_region_results to indicate that RetryableMultiRegion should return response from all regions, or raise the first Error if there is any.

As @andylokandy suggests, for lower module coupling, other than using a parameter to control behavior of RetryableMultiRegion, it would be better that RetryableMultiRegion returns a generic response, and allows downstream plans to extract what they need from the response.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/request/plan.rs and the preserve_region_results change from #332, then trace RetryableMultiRegion and the downstream plans that consume its response. Done means replacing the parameter-driven behavior with a generic response that lets downstream plans extract the needed results while preserving the stated error behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
distributed-systems
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.