Logrus instances and override
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 362
- Forks
- 274
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 13
Description
In our codebase, we have 2 to 3 instances of TiKV in certain circumstances. All of them are currently logging through the logrus standard logger.
It would be preferable if each tikv-client instance had his own logger attached to it so it would be possible to configure them differently based on the instance directly.
Every logger could use the standard logger by default and a new method could enable configure a different logger by default.
I'm opening the issue here to get a feeling if this would be an accept PR on this repository, at some point in time, I could take the issue and make the necessary code changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating how tikv-client instances are created and where the logrus standard logger is used; then determine how per-instance logger configuration should work. Done means each instance can use the standard logger by default while allowing a different logger to be configured independently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100