tikv / tikv/client-go

Replace unistore with mockstore for `testAsyncCommitFailSuite`

Open
#441 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
362
Forks
274
Avg merge
4d 19m
Merged PRs (30d)
12

Description

Replace

https://github.com/tikv/client-go/blob/8c3f29a55f1015e6d4d5cf2e121999ddb224833f/integration_tests/async_commit_test.go#L80-L83

with

client, cluster, pdClient, err := testutils.NewMockTiKV("", nil)
s.Require().Nil(err) 
testutils.BootstrapWithSingleStore(cluster)

Then make sure tests can pass.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open integration_tests/async_commit_test.go around lines 80-83 and inspect testAsyncCommitFailSuite. Replace the existing unistore setup with the specified testutils.NewMockTiKV and BootstrapWithSingleStore calls, then run the relevant async commit tests. Done means the updated tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.