Too many goroutines in commit phase affect performance
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 362
- Forks
- 274
- Avg merge
- 4d 19m
- Merged PRs (30d)
- 12
Description
@BusyJay found too many goroutines in commit phase affect performance a lot. The committer-concurrency is 1024. The region size on left side is smaller than right side.
It's not an apple to apple comparison, because larger region results in larger requests and batch, but the throughput of TiKV is the same.
Disregarding TiKV, too many goroutines affects GC, schedule of TSO goroutine and so on. We can improve it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named. Start by profiling the commit phase and tracing the committer-concurrency setting, then compare goroutine, GC, scheduling, and throughput behavior; done means reducing unnecessary goroutine impact without harming throughput.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100