tidyverts / tidyverts/fabletools
Reconsider how coherent list models store coherency relations
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 98
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Currently coherent list models (e.g. lst_mint_mdl) require the key_data() of the mable to be passed in via the forecast.mdl_df() method - this dependency seems fragile and could be improved by storing the coherency structure when reconcile() is called. This also relates to how coherent list models should behave for other functions (e.g. fitted() should give coherent fitted values).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing reconcile(), forecast.mdl_df(), and fitted() for coherent list models such as lst_mint_mdl; done means the coherency structure is stored when reconcile() is called and related functions, including fitted(), behave coherently without requiring key_data() through forecast.mdl_df().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data, machine-learning
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100