tidyverts / tidyverts/fabletools
Rework model definitions
Open
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 98
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
The current system of reusing a single R6 class for each slice of the data (key) has a few issues:
- Cannot easily choose models by row (https://github.com/tidyverts/fable/issues/54)
- More overhead for model setup
- Has been the cause of a few bugs (https://github.com/tidyverts/fabletools/issues/326)
Setting up a simpler model structure that can be vectorised with vctrs may help here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the current R6 model structure, then review tidyverts/fable#54 and tidyverts/fabletools#326 for the reported row-selection, setup-overhead, and bug concerns. A completed change would define a simpler model structure that can be vectorised with vctrs and addresses those concerns.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100