tidyverts / tidyverts/fabletools

Extremely slow augment() in my mable

Open
#208 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
98
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Dear colleagues,

I have a grouped ts_tibble where I am fitting ETS, TSLM, ARIMA, NNETAR and a combination model using all of this 4:

ts_models <- ts_tibble %>% 
  model(arima = ARIMA(snsr_val_clean),
        nnarx = NNETAR(snsr_val_clean),
        tslm = TSLM(snsr_val_clean ~ trend()),
        ets = ETS(snsr_val_clean),
        ensemble_full =  combination_model(ARIMA(snsr_val_clean),
                                           NNETAR(snsr_val_clean),
                                           TSLM(snsr_val_clean ~ trend()),
                                           ETS(snsr_val_clean)))

The fitting takes 486.989s according to tictoc() and runs in paralell without problems (I am loading purrr+furrr+future). However when trying to inspect the mable object as:

augment(ts_models)
It has been running for 1h and a half in single core and I can not access the results.

BR
/Edgar

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported call to augment(ts_models) using the grouped ts_tibble and model specification shown in the issue, comparing its runtime with model fitting. Trace the augment entry point and inspect the combination model path; done means identifying the source of the excessive runtime and demonstrating an improvement with a focused regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.