tidyverse / tidyverse/ggplot2

In theme, could aspect.ratio be renamed panel.aspect.ratio?

Open Beginner friendly
#6,889 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

themes :dancer:
Dominant language
R
Stars
7k
Forks
2.1k
Avg merge
59m
Merged PRs (30d)
2

Description

In theme, could aspect.ratio be renamed panel.aspect.ratio to express clearly that (1) it relates to the panel - and (2) it links to panel.widths and panel.heights, which are similar ways to adjust the panel dimensions. Nitpicky, I know, sorry. Feel free to close

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for the theme setting aspect.ratio and the related panel.widths and panel.heights names. Check every use and any coverage for theme settings before making the rename. Done means the setting is consistently named panel.aspect.ratio without breaking existing tests or references.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.