tidyverse / tidyverse/ggplot2

Should `theme(palette.*)` be normal theme elements?

Open
#6,847 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

themes :dancer:
Dominant language
R
Stars
7k
Forks
2.1k
Avg merge
59m
Merged PRs (30d)
2

Description

Split from https://github.com/tidyverse/ggplot2/issues/6827#issuecomment-4236523340.

The palette elements in the theme hierarchy are supported both for extensions and for end users wishing to change default palettes. They currently are not documented as parameters for theme() and do not work like with calc_element() in the same way as other elements. Should they behave like normal theme elements?

I think the status quo is a little confusing where they are used in the documentation example but not documented as parameters.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by comparing the theme() parameter documentation with calc_element() behavior for theme(palette.*), including the documentation example. Done means deciding whether palette elements should be documented and behave as normal theme elements, then covering the chosen behavior with tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization, design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.