tidyverse / tidyverse/ggplot2

variable inherit.aes behavior for geom_vline and friends

Open
#6,833 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

layers :chart_with_upwards_trend:
Dominant language
R
Stars
7k
Forks
2.1k
Avg merge
59m
Merged PRs (30d)
2

Description

In #6633 the inherit.aes behavior is exposed to the user, but the default is set to FALSE, which means that that layer is not in sync with most user-facing geom_* layers. I think setting this to NULL (so still exposing to user), and turning inheritance off if xintercept is non-null would feel more consistent when this geom_* family is used in a non-annotative way. Thoughts?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issue #6633 and the current inherit.aes behavior of geom_vline and related geoms. Compare the proposed NULL default with cases where xintercept is non-null, then seek agreement on the intended rule; done means the behavior is specified clearly enough to implement and verify.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.